drm/amd/display: Initialize stream_update to zero (c448a53a) · Commits · e / devices / android_kernel_fairphone_FP5

[Why] The stream_update struct is left unitialized but DC will access its fields. This usually results in global state validation occur during any atomic commit with state->allow_modeset = true. [How] Initialize the struct to zero for every stream we check. Signed-off-by:

Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Reviewed-by:

David Francis <David.Francis@amd.com> Acked-by:

Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Signed-off-by:

Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -5773,7 +5773,6 @@ dm_determine_update_type_for_commit(struct dc *dc,

		struct dc_surface_update *updates;
		struct dc_plane_state *surface;
		struct dc_stream_update stream_update;
		enum surface_update_type update_type = UPDATE_TYPE_FAST;

		updates = kcalloc(MAX_SURFACES, sizeof(*updates), GFP_KERNEL);
		@@ -5787,6 +5786,8 @@ dm_determine_update_type_for_commit(struct dc *dc,
		}

		for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
		struct dc_stream_update stream_update = { 0 };

		new_dm_crtc_state = to_dm_crtc_state(new_crtc_state);
		old_dm_crtc_state = to_dm_crtc_state(old_crtc_state);
		num_plane = 0;