Commit c4351d98 authored Aug 28, 2016 by Markus Elfring Committed by Helge Deller Sep 20, 2016

parisc: Use kmalloc_array() in add_system_map_addresses()



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Helge Deller <deller@gmx.de>

parent 5baf919d

arch/parisc/kernel/inventory.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -506,7 +506,7 @@ add_system_map_addresses(struct parisc_device *dev, int num_addrs,
		long status;
		struct pdc_system_map_addr_info addr_result;

		dev->addr = kmalloc(num_addrs * sizeof(unsigned long), GFP_KERNEL);
		dev->addr = kmalloc_array(num_addrs, sizeof(*dev->addr), GFP_KERNEL);
		if(!dev->addr) {
		printk(KERN_ERR "%s %s(): memory allocation failure\n",
		__FILE__, __func__);