Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c421651f authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/siw: Add missing rtnl_lock around access to ifa 



ifa is protected by rcu or rtnl, add the missing locking. In this case we
have to use rtnl since siw_listen_address() is sleeping.

Fixes: 6c52fdc2 ("rdma/siw: connection management")
Reviewed-by: default avatarBernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 775a41e2

drivers/infiniband/sw/siw/siw_cm.c

+2 −0
Original line number Diff line number Diff line
@@ -1975,6 +1975,7 @@ int siw_create_listen(struct iw_cm_id *id, int backlog) 
			id, &s_laddr.sin_addr, ntohs(s_laddr.sin_port),

			&s_raddr->sin_addr, ntohs(s_raddr->sin_port));



		rtnl_lock();

		for_ifa(in_dev)

		{

			if (ipv4_is_zeronet(s_laddr.sin_addr.s_addr) ||
@@ -1989,6 +1990,7 @@ int siw_create_listen(struct iw_cm_id *id, int backlog) 
			}

		}

		endfor_ifa(in_dev);

		rtnl_unlock();

		in_dev_put(in_dev);

	} else if (id->local_addr.ss_family == AF_INET6) {

		struct inet6_dev *in6_dev = in6_dev_get(dev);