Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c39747f7 authored by Gao Xiang's avatar Gao Xiang Committed by Greg Kroah-Hartman
Browse files

erofs: update erofs_inode_is_data_compressed helper 

As Christoph said, "This looks like a really obsfucated
way to write:
	return datamode == EROFS_INODE_FLAT_COMPRESSION ||
		datamode == EROFS_INODE_FLAT_COMPRESSION_LEGACY; "

Although I had my own consideration, it's the right way for now.

[1] https://lore.kernel.org/r/20190829095954.GB20598@infradead.org/


Reported-by: default avatarChristoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarGao Xiang <gaoxiang25@huawei.com>
Link: https://lore.kernel.org/r/20190904020912.63925-6-gaoxiang25@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed34aa4a

fs/erofs/erofs_fs.h

+2 −3
Original line number Diff line number Diff line
@@ -62,9 +62,8 @@ enum { 


static inline bool erofs_inode_is_data_compressed(unsigned int datamode)

{

	if (datamode == EROFS_INODE_FLAT_COMPRESSION)

		return true;

	return datamode == EROFS_INODE_FLAT_COMPRESSION_LEGACY;

	return datamode == EROFS_INODE_FLAT_COMPRESSION ||

		datamode == EROFS_INODE_FLAT_COMPRESSION_LEGACY;

}



/* bit definitions of inode i_advise */