Commit c3422ad5 authored Mar 18, 2019 by Gustavo A. R. Silva Committed by Sebastian Reichel Apr 05, 2019

power: supply: axp288_charger: Fix unchecked return value



Currently there is no check on platform_get_irq() return value
in case it fails, hence never actually reporting any errors and
causing unexpected behavior when using such value as argument
for function regmap_irq_get_virq().

Fix this by adding a proper check, a message reporting any errors
and returning *pirq*

Addresses-Coverity-ID: 1443940 ("Improper use of negative value")
Fixes: 843735b7 ("power: axp288_charger: axp288 charger driver")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

parent f0459fe1

drivers/power/supply/axp288_charger.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -833,6 +833,10 @@ static int axp288_charger_probe(struct platform_device *pdev)
		/* Register charger interrupts */
		for (i = 0; i < CHRG_INTR_END; i++) {
		pirq = platform_get_irq(info->pdev, i);
		if (pirq < 0) {
		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq);
		return pirq;
		}
		info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
		if (info->irq[i] < 0) {
		dev_warn(&info->pdev->dev,