Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c32e3d1b authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] atomisp: putting NULs in the wrong place 



We're putting the NUL terminators one space beyond where they belong.
This doesn't show up in testing because all but the callers put a NUL in
the correct place themselves.  LOL.  It causes a static checker warning
about buffer overflows.

Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2")

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent d1fec5bd

drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_include/string_support.h

+2 −2
Original line number Diff line number Diff line
@@ -117,7 +117,7 @@ STORAGE_CLASS_INLINE int strncpy_s( 


	/* dest_str is big enough for the len */

	strncpy(dest_str, src_str, len);

	dest_str[len+1] = '\0';

	dest_str[len] = '\0';

	return 0;

}
@@ -157,7 +157,7 @@ STORAGE_CLASS_INLINE int strcpy_s( 


	/* dest_str is big enough for the len */

	strncpy(dest_str, src_str, len);

	dest_str[len+1] = '\0';

	dest_str[len] = '\0';

	return 0;

}