Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2fd3446 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Kalle Valo
Browse files

iwl4965: Fix a memory leak in error handling code of __il4965_up 



When il4965_hw_nic_init in __il4965_up fails, the memory allocated by
iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not freed.

This patches adds il_dealloc_bcast_stations in the error handling code of
__il4965_up to fix this problem.

This patch has been tested in real device, and it actually fixes the bug.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@163.com>
Acked-by: default avatarStanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: default avatarJulian Calaby <julian.calaby@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 37190b26

drivers/net/wireless/intel/iwlegacy/4965-mac.c

+1 −0
Original line number Diff line number Diff line
@@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il) 
	ret = il4965_hw_nic_init(il);

	if (ret) {

		IL_ERR("Unable to init nic\n");

		il_dealloc_bcast_stations(il);

		return ret;

	}