Commit c2ee2243 authored Jun 12, 2018 by Nicholas Mc Guire Committed by Mauro Carvalho Chehab Jun 28, 2018

media: stm32-dcmi: add mandatory of_node_put() in success path

The endpoint allocated by of_graph_get_next_endpoint() needs an of_node_put()
in both error and success path. As ep is not used the refcount decrement
can be right after the last use of ep.

Fixes: commit 37404f91 ("[media] stm32-dcmi: STM32 DCMI camera interface driver")

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent f8eb8e5c

drivers/media/platform/stm32/stm32-dcmi.c

+2 −3

Original line number	Original line	Diff line number	Diff line
	@@ -1572,10 +1572,9 @@ static int dcmi_graph_parse(struct stm32_dcmi dcmi, struct device_node node)
	return -EINVAL;		return -EINVAL;

	remote = of_graph_get_remote_port_parent(ep);		remote = of_graph_get_remote_port_parent(ep);
	if (!remote) {
	of_node_put(ep);		of_node_put(ep);
			if (!remote)
	return -EINVAL;		return -EINVAL;
	}

	/* Remote node to connect */		/* Remote node to connect */
	dcmi->entity.node = remote;		dcmi->entity.node = remote;