Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2d18126 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: ccg: fix missing unlock on error in ccg_cmd_write_flash_row() 



Add the missing unlock before return from function ccg_cmd_write_flash_row()
in the error handling case.

Fixes: 5c9ae5a8 ("usb: typec: ucsi: ccg: add firmware flashing support")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f2c54e7

drivers/usb/typec/ucsi/ucsi_ccg.c

+1 −0
Original line number Diff line number Diff line
@@ -631,6 +631,7 @@ ccg_cmd_write_flash_row(struct ucsi_ccg *uc, u16 row, 
	ret = i2c_master_send(client, buf, CCG4_ROW_SIZE + 2);

	if (ret != CCG4_ROW_SIZE + 2) {

		dev_err(uc->dev, "REG_FLASH_RW_MEM write fail %d\n", ret);

		mutex_unlock(&uc->lock);

		return ret < 0 ? ret : -EIO;

	}