Commit c2c7d84f authored Dec 20, 2018 by NeilBrown Committed by Anna Schumaker Jan 02, 2019

NFS: remove unnecessary test for IS_ERR(cred)



As gte_current_cred() cannot return an error,
this test is not necessary.
It hasn't been necessary for years, but it wasn't so obvious
before.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

parent 07e10308

fs/nfs/unlink.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -348,11 +348,6 @@ nfs_async_rename(struct inode old_dir, struct inode new_dir,
		task_setup_data.callback_data = data;

		data->cred = get_current_cred();
		if (IS_ERR(data->cred)) {
		struct rpc_task *task = ERR_CAST(data->cred);
		kfree(data);
		return task;
		}

		msg.rpc_argp = &data->args;
		msg.rpc_resp = &data->res;