Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2ade654 authored by Rob Herring's avatar Rob Herring Committed by Tony Lindgren
Browse files

memory: omap-gpmc: Use of_node_name_eq for node name comparisons 



Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

For instances using of_node_cmp, this has the side effect of now using
case sensitive comparisons. This should not matter for any FDT based
system which this is.

Cc: Roger Quadros <rogerq@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 04491ab0

drivers/memory/omap-gpmc.c

+4 −4
Original line number Diff line number Diff line
@@ -2060,7 +2060,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, 
	 * timings.

	 */

	name = gpmc_cs_get_name(cs);

	if (name && of_node_cmp(child->name, name) == 0)

	if (name && of_node_name_eq(child, name))

		goto no_timings;



	ret = gpmc_cs_request(cs, resource_size(&res), &base);
@@ -2068,7 +2068,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, 
		dev_err(&pdev->dev, "cannot request GPMC CS %d\n", cs);

		return ret;

	}

	gpmc_cs_set_name(cs, child->name);

	gpmc_cs_set_name(cs, child->full_name);



	gpmc_read_settings_dt(child, &gpmc_s);

	gpmc_read_timings_dt(child, &gpmc_t);
@@ -2113,7 +2113,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, 
		goto err;

	}



	if (of_node_cmp(child->name, "nand") == 0) {

	if (of_node_name_eq(child, "nand")) {

		/* Warn about older DT blobs with no compatible property */

		if (!of_property_read_bool(child, "compatible")) {

			dev_warn(&pdev->dev,
@@ -2123,7 +2123,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, 
		}

	}



	if (of_node_cmp(child->name, "onenand") == 0) {

	if (of_node_name_eq(child, "onenand")) {

		/* Warn about older DT blobs with no compatible property */

		if (!of_property_read_bool(child, "compatible")) {

			dev_warn(&pdev->dev,