Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2a7dca0 authored by Alessio Igor Bogani's avatar Alessio Igor Bogani Committed by John W. Linville
Browse files

rtlwifi: fix places where uninitialized data is used 



drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function

This work was supported by a hardware donation from the CE Linux Forum.

Signed-off-by: default avatarAlessio Igor Bogani <abogani@kernel.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 701c2be0

drivers/net/wireless/rtlwifi/rtl8192ce/trx.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw, 
	struct rtl_priv *rtlpriv = rtl_priv(hw);

	struct rtl_priv *rtlpriv = rtl_priv(hw);

	struct phy_sts_cck_8192s_t *cck_buf;

	struct phy_sts_cck_8192s_t *cck_buf;

	s8 rx_pwr_all, rx_pwr[4];

	s8 rx_pwr_all, rx_pwr[4];

	u8 rf_rx_num, evm, pwdb_all;

	u8 evm, pwdb_all, rf_rx_num = 0;

	u8 i, max_spatial_stream;

	u8 i, max_spatial_stream;

	u32 rssi, total_rssi;

	u32 rssi, total_rssi = 0;

	bool is_cck_rate;

	bool is_cck_rate;





	is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);

	is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
@@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw, 
					       struct rtl_stats *pstats)

					       struct rtl_stats *pstats)

{

{

	struct rtl_priv *rtlpriv = rtl_priv(hw);

	struct rtl_priv *rtlpriv = rtl_priv(hw);

	int weighting;

	int weighting = 0;





	if (rtlpriv->stats.recv_signal_power == 0)

	if (rtlpriv->stats.recv_signal_power == 0)

		rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;

		rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;