Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c28dcbce authored by Dan Carpenter's avatar Dan Carpenter Committed by Kalle Valo
Browse files

ath10k: fix a NULL vs IS_ERR() check 



The devm_memremap() function doesn't return NULLs, it returns error
pointers.

Fixes: ba94c753 ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 87659675

drivers/net/wireless/ath/ath10k/qmi.c

+2 −2
Original line number Diff line number Diff line
@@ -931,9 +931,9 @@ static int ath10k_qmi_setup_msa_resources(struct ath10k_qmi *qmi, u32 msa_size) 
		qmi->msa_mem_size = resource_size(&r);

		qmi->msa_va = devm_memremap(dev, qmi->msa_pa, qmi->msa_mem_size,

					    MEMREMAP_WT);

		if (!qmi->msa_va) {

		if (IS_ERR(qmi->msa_va)) {

			dev_err(dev, "failed to map memory region: %pa\n", &r.start);

			return -EBUSY;

			return PTR_ERR(qmi->msa_va);

		}

	} else {

		qmi->msa_va = dmam_alloc_coherent(dev, msa_size,