Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c24e7daf authored by Fabio Estevam's avatar Fabio Estevam Committed by Jonathan Cameron
Browse files

iio: pressure: hid-sensor-press: Fix memory leak in probe() 



'channels' is allocated via kmemdup and it is never freed in the
subsequent error paths.

Use 'indio_dev->channels' directly instead, so that we avoid such
memory leak problem.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 2bd04628

drivers/iio/pressure/hid-sensor-press.c

+6 −6
Original line number Diff line number Diff line
@@ -262,7 +262,6 @@ static int hid_press_probe(struct platform_device *pdev) 
	struct iio_dev *indio_dev;

	struct press_state *press_state;

	struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;

	struct iio_chan_spec *channels;



	indio_dev = devm_iio_device_alloc(&pdev->dev,

				sizeof(struct press_state));
@@ -282,20 +281,21 @@ static int hid_press_probe(struct platform_device *pdev) 
		return ret;

	}



	channels = kmemdup(press_channels, sizeof(press_channels), GFP_KERNEL);

	if (!channels) {

	indio_dev->channels = kmemdup(press_channels, sizeof(press_channels),

				      GFP_KERNEL);

	if (!indio_dev->channels) {

		dev_err(&pdev->dev, "failed to duplicate channels\n");

		return -ENOMEM;

	}



	ret = press_parse_report(pdev, hsdev, channels,

	ret = press_parse_report(pdev, hsdev,

				 (struct iio_chan_spec *)indio_dev->channels,

				 HID_USAGE_SENSOR_PRESSURE, press_state);

	if (ret) {

		dev_err(&pdev->dev, "failed to setup attributes\n");

		goto error_free_dev_mem;

	}



	indio_dev->channels = channels;

	indio_dev->num_channels =

				ARRAY_SIZE(press_channels);

	indio_dev->dev.parent = &pdev->dev;