Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2057701 authored by Alexey Kardashevskiy's avatar Alexey Kardashevskiy Committed by Michael Ellerman
Browse files

powerpc/powernv/eeh/npu: Fix uninitialized variables in opal_pci_eeh_freeze_status 



The current implementation of the OPAL_PCI_EEH_FREEZE_STATUS call in
skiboot's NPU driver does not touch the pci_error_type parameter so
it might have garbage but the powernv code analyzes it nevertheless.

This initializes pcierr and fstate to zero in all call sites.

Signed-off-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: default avatarSam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent a25de7af

arch/powerpc/platforms/powernv/eeh-powernv.c

+4 −4
Original line number Diff line number Diff line
@@ -564,8 +564,8 @@ static void pnv_eeh_get_phb_diag(struct eeh_pe *pe) 
static int pnv_eeh_get_phb_state(struct eeh_pe *pe)

{

	struct pnv_phb *phb = pe->phb->private_data;

	u8 fstate;

	__be16 pcierr;

	u8 fstate = 0;

	__be16 pcierr = 0;

	s64 rc;

	int result = 0;
@@ -603,8 +603,8 @@ static int pnv_eeh_get_phb_state(struct eeh_pe *pe) 
static int pnv_eeh_get_pe_state(struct eeh_pe *pe)

{

	struct pnv_phb *phb = pe->phb->private_data;

	u8 fstate;

	__be16 pcierr;

	u8 fstate = 0;

	__be16 pcierr = 0;

	s64 rc;

	int result;

arch/powerpc/platforms/powernv/pci-ioda.c

+2 −2
Original line number Diff line number Diff line
@@ -602,8 +602,8 @@ static int pnv_ioda_unfreeze_pe(struct pnv_phb *phb, int pe_no, int opt) 
static int pnv_ioda_get_pe_state(struct pnv_phb *phb, int pe_no)

{

	struct pnv_ioda_pe *slave, *pe;

	u8 fstate, state;

	__be16 pcierr;

	u8 fstate = 0, state;

	__be16 pcierr = 0;

	s64 rc;



	/* Sanity check on PE number */

arch/powerpc/platforms/powernv/pci.c

+2 −2
Original line number Diff line number Diff line
@@ -602,8 +602,8 @@ static void pnv_pci_handle_eeh_config(struct pnv_phb *phb, u32 pe_no) 
static void pnv_pci_config_check_eeh(struct pci_dn *pdn)

{

	struct pnv_phb *phb = pdn->phb->private_data;

	u8	fstate;

	__be16	pcierr;

	u8	fstate = 0;

	__be16	pcierr = 0;

	unsigned int pe_no;

	s64	rc;