Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1c58262 authored by Hans Verkuil's avatar Hans Verkuil Committed by Greg Kroah-Hartman
Browse files

media: platform: mediatek: vpu: fix NULL ptr dereference 



[ Upstream commit 3df55cd773e8603b623425cc97b05e542854ad27 ]

If pdev is NULL, then it is still dereferenced.

This fixes this smatch warning:

drivers/media/platform/mediatek/vpu/mtk_vpu.c:570 vpu_load_firmware() warn: address of NULL pointer 'pdev'

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ef009fe2

drivers/media/platform/mtk-vpu/mtk_vpu.c

+4 −2
Original line number Diff line number Diff line
@@ -529,15 +529,17 @@ static int load_requested_vpu(struct mtk_vpu *vpu, 
int vpu_load_firmware(struct platform_device *pdev)

{

	struct mtk_vpu *vpu;

	struct device *dev = &pdev->dev;

	struct device *dev;

	struct vpu_run *run;

	int ret;



	if (!pdev) {

		dev_err(dev, "VPU platform device is invalid\n");

		pr_err("VPU platform device is invalid\n");

		return -EINVAL;

	}



	dev = &pdev->dev;



	vpu = platform_get_drvdata(pdev);

	run = &vpu->run;