Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c158c3bf authored by Roy Franz's avatar Roy Franz Committed by Matt Fleming
Browse files

boot, efi: Remove redundant memset() 



Remove a redundant memset() call from efi_relocate_kernel() that
was clearing memory that would be used by BSS in non-compressed
images loaded with this function.  This clear was redundant with
the clearing done in the image itself, and also implemented incorrectly
with a 0 length.

Signed-off-by: default avatarRoy Franz <roy.franz@linaro.org>
Acked-by: default avatarMark Salter <msalter@redhat.com>
Signed-off-by: default avatarMatt Fleming <matt.fleming@intel.com>
parent 722da9d2

drivers/firmware/efi/efi-stub-helper.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -567,8 +567,6 @@ static efi_status_t efi_relocate_kernel(efi_system_table_t *sys_table_arg, 
	 * have been allocated by UEFI, so we can safely use memcpy.

	 * have been allocated by UEFI, so we can safely use memcpy.

	 */

	 */

	memcpy((void *)new_addr, (void *)cur_image_addr, image_size);

	memcpy((void *)new_addr, (void *)cur_image_addr, image_size);

	/* Zero any extra space we may have allocated for BSS. */

	memset((void *)(new_addr + image_size), alloc_size - image_size, 0);





	/* Return the new address of the relocated image. */

	/* Return the new address of the relocated image. */

	*image_addr = new_addr;

	*image_addr = new_addr;