Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c14ab52d authored by qctecmdr's avatar qctecmdr Committed by Gerrit - the friendly Code Review server
Browse files

Merge "asoc: codecs: Fix out of bounds access in register show function"

parents a3a76f4a d173af67

asoc/codecs/wsa883x/wsa883x.c

+6 −1
Original line number Diff line number Diff line
@@ -254,7 +254,12 @@ static ssize_t swr_slave_reg_show(struct swr_device *pdev, char __user *ubuf, 
		swr_read(pdev, pdev->dev_num, i, &reg_val, 1);

		len = snprintf(tmp_buf, sizeof(tmp_buf), "0x%.3x: 0x%.2x\n", i,

			       (reg_val & 0xFF));

		if (((total + len) >= count - 1) || (len < 0))

		if (len < 0) {

			pr_err("%s: fail to fill the buffer\n", __func__);

			total = -EFAULT;

			goto copy_err;

		}

		if ((total + len) >= count - 1)

			break;

		if (copy_to_user((ubuf + total), tmp_buf, len)) {

			pr_err("%s: fail to copy reg dump\n", __func__);