Commit c122daa0 authored Mar 24, 2023 by Tomas Henzl Committed by Greg Kroah-Hartman Apr 05, 2023

scsi: megaraid_sas: Fix crash after a double completion



[ Upstream commit 2309df27111a51734cb9240b4d3c25f2f3c6ab06 ]

When a physical disk is attached directly "without JBOD MAP support" (see
megasas_get_tm_devhandle()) then there is no real error handling in the
driver.  Return FAILED instead of SUCCESS.

Fixes: 18365b13 ("megaraid_sas: Task management support")
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Link: https://lore.kernel.org/r/20230324150134.14696-1-thenzl@redhat.com


Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 317c07d3

drivers/scsi/megaraid/megaraid_sas_fusion.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4659,7 +4659,7 @@ int megasas_task_abort_fusion(struct scsi_cmnd *scmd)
		devhandle = megasas_get_tm_devhandle(scmd->device);

		if (devhandle == (u16)ULONG_MAX) {
		ret = SUCCESS;
		ret = FAILED;
		sdev_printk(KERN_INFO, scmd->device,
		"task abort issued for invalid devhandle\n");
		mutex_unlock(&instance->reset_mutex);
		@@ -4729,7 +4729,7 @@ int megasas_reset_target_fusion(struct scsi_cmnd *scmd)
		devhandle = megasas_get_tm_devhandle(scmd->device);

		if (devhandle == (u16)ULONG_MAX) {
		ret = SUCCESS;
		ret = FAILED;
		sdev_printk(KERN_INFO, scmd->device,
		"target reset issued for invalid devhandle\n");
		mutex_unlock(&instance->reset_mutex);