Commit c10b90d8 authored Apr 05, 2013 by Li Fei Committed by Ohad Ben-Cohen Apr 05, 2013

hwspinlock: fix __hwspin_lock_request error path



Even in failed case of pm_runtime_get_sync, the usage_count
is incremented. In order to keep the usage_count with correct
value and runtime power management to behave correctly, call
pm_runtime_put_noidle in such case.

In __hwspin_lock_request, module_put is also called before
return in pm_runtime_get_sync failed case.

Cc: stable@vger.kernel.org
Signed-off-by Liu Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Li Fei <fei.li@intel.com>
[edit commit log]
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>

parent f6161aa1

drivers/hwspinlock/hwspinlock_core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -416,6 +416,8 @@ static int __hwspin_lock_request(struct hwspinlock *hwlock)
		ret = pm_runtime_get_sync(dev);
		if (ret < 0) {
		dev_err(dev, "%s: can't power on device\n", __func__);
		pm_runtime_put_noidle(dev);
		module_put(dev->driver->owner);
		return ret;
		}