Commit c0d4010e authored May 28, 2010 by Linus Walleij Committed by Samuel Ortiz Aug 12, 2010

mfd: AB8500 mask off irrelevant bits from the SPI message



The registers on the AB8500 are only 8 bits wide, so the content
of the remaining bits is undefined. Let's mask off the undefined
stuff when returning a register in an SPI read.

Acked-by: Rabin Vincent <rabin.vincent@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent eb6e8ddf

drivers/mfd/ab8500-spi.c

+6 −1

Original line number	Original line	Diff line number	Diff line
	@@ -68,7 +68,12 @@ static int ab8500_spi_read(struct ab8500 *ab8500, u16 addr)

	ret = spi_sync(spi, &msg);		ret = spi_sync(spi, &msg);
	if (!ret)		if (!ret)
	ret = ab8500->rx_buf[0];		/*
			* Only the 8 lowermost bytes are
			* defined with value, the rest may
			* vary depending on chip/board noise.
			*/
			ret = ab8500->rx_buf[0] & 0xFFU;

	return ret;		return ret;
	}		}