Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0769f09 authored by Zhipeng Lu's avatar Zhipeng Lu Committed by Greg Kroah-Hartman
Browse files

drm/radeon/dpm: fix a memleak in sumo_parse_power_table 



[ Upstream commit 0737df9ed0997f5b8addd6e2b9699a8c6edba2e4 ]

The rdev->pm.dpm.ps allocated by kcalloc should be freed in every
following error-handling path. However, in the error-handling of
rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed,
resulting in a memleak in this function.

Fixes: 80ea2c12 ("drm/radeon/kms: add dpm support for sumo asics (v2)")
Signed-off-by: default avatarZhipeng Lu <alexious@zju.edu.cn>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5d12c5d7

drivers/gpu/drm/radeon/sumo_dpm.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -1493,8 +1493,10 @@ static int sumo_parse_power_table(struct radeon_device *rdev) 
		non_clock_array_index = power_state->v2.nonClockInfoIndex;

		non_clock_array_index = power_state->v2.nonClockInfoIndex;

		non_clock_info = (struct _ATOM_PPLIB_NONCLOCK_INFO *)

		non_clock_info = (struct _ATOM_PPLIB_NONCLOCK_INFO *)

			&non_clock_info_array->nonClockInfo[non_clock_array_index];

			&non_clock_info_array->nonClockInfo[non_clock_array_index];

		if (!rdev->pm.power_state[i].clock_info)

		if (!rdev->pm.power_state[i].clock_info) {

			kfree(rdev->pm.dpm.ps);

			return -EINVAL;

			return -EINVAL;

		}

		ps = kzalloc(sizeof(struct sumo_ps), GFP_KERNEL);

		ps = kzalloc(sizeof(struct sumo_ps), GFP_KERNEL);

		if (ps == NULL) {

		if (ps == NULL) {

			kfree(rdev->pm.dpm.ps);

			kfree(rdev->pm.dpm.ps);