Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0491d4e authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: pcl816: use comedi_buf_write_samples() 



For aesthetics, use comedi_buf_write_samples() to add the sample to the
async buffer.

The core will add the COMEDI_CB_BLOCK event when data is written to the
async buffer. Remove the unnecessary event in the driver.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 76cb5019

drivers/staging/comedi/drivers/pcl816.c

+3 −3
Original line number Diff line number Diff line
@@ -289,8 +289,6 @@ static bool pcl816_ai_next_chan(struct comedi_device *dev, 
	struct pcl816_private *devpriv = dev->private;

	struct comedi_cmd *cmd = &s->async->cmd;



	s->async->events |= COMEDI_CB_BLOCK;



	s->async->cur_chan++;

	if (s->async->cur_chan >= cmd->chanlist_len) {

		s->async->cur_chan = 0;
@@ -313,10 +311,12 @@ static void transfer_from_dma_buf(struct comedi_device *dev, 
				  unsigned short *ptr,

				  unsigned int bufptr, unsigned int len)

{

	unsigned short val;

	int i;



	for (i = 0; i < len; i++) {

		comedi_buf_put(s, ptr[bufptr++]);

		val = ptr[bufptr++];

		comedi_buf_write_samples(s, &val, 1);



		if (!pcl816_ai_next_chan(dev, s))

			return;