Unverified Commit bfecfd6e authored Jan 19, 2019 by Boris Brezillon Committed by Mark Brown Jan 21, 2019

spi: spi-mem: Fix a memory leak in spi_mem_dirmap_destroy()



The dirmap descriptor object allocated in spi_mem_dirmap_create is
never freed. Add a kfree(desc) in spi_mem_dirmap_destroy().

Fixes: aa167f3f ("spi: spi-mem: Add a new API to support direct mapping")
Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 5c0c4ec9

drivers/spi/spi-mem.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -547,6 +547,8 @@ void spi_mem_dirmap_destroy(struct spi_mem_dirmap_desc *desc)

	if (!desc->nodirmap && ctlr->mem_ops && ctlr->mem_ops->dirmap_destroy)		if (!desc->nodirmap && ctlr->mem_ops && ctlr->mem_ops->dirmap_destroy)
	ctlr->mem_ops->dirmap_destroy(desc);		ctlr->mem_ops->dirmap_destroy(desc);

			kfree(desc);
	}		}
	EXPORT_SYMBOL_GPL(spi_mem_dirmap_destroy);		EXPORT_SYMBOL_GPL(spi_mem_dirmap_destroy);