Commit bfc88826 authored Sep 13, 2018 by Deepak Rawat Committed by Thomas Hellstrom Sep 20, 2018

drm/vmwgfx: don't check for old_crtc_state enable status



During atomic check to prepare the new topology no need to check if
old_crtc_state was enabled or not. This will cause atomic_check to fail
because due to connector routing a crtc can be in atomic_state even if
there was no change to enable status.

Detected this issue with igt run.

Signed-off-by: Deepak Rawat <drawat@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>

parent 8ca4fff9

drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1615,7 +1615,7 @@ static int vmw_kms_check_topology(struct drm_device *dev,
		struct drm_connector_state *conn_state;
		struct vmw_connector_state *vmw_conn_state;

		if (!new_crtc_state->enable && old_crtc_state->enable) {
		if (!new_crtc_state->enable) {
		rects[i].x1 = 0;
		rects[i].y1 = 0;
		rects[i].x2 = 0;