Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit beaf226b authored by Miklos Szeredi's avatar Miklos Szeredi
Browse files

posix_acl: don't ignore return value of posix_acl_create_masq() 



Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
parent 280db3c8

fs/posix_acl.c

+6 −5
Original line number Diff line number Diff line
@@ -598,13 +598,14 @@ posix_acl_create(struct inode *dir, umode_t *mode, 
	if (IS_ERR(p))

		return PTR_ERR(p);



	ret = -ENOMEM;

	clone = posix_acl_clone(p, GFP_NOFS);

	if (!clone)

		goto no_mem;

		goto err_release;



	ret = posix_acl_create_masq(clone, mode);

	if (ret < 0)

		goto no_mem_clone;

		goto err_release_clone;



	if (ret == 0)

		posix_acl_release(clone);
@@ -618,11 +619,11 @@ posix_acl_create(struct inode *dir, umode_t *mode, 


	return 0;



no_mem_clone:

err_release_clone:

	posix_acl_release(clone);

no_mem:

err_release:

	posix_acl_release(p);

	return -ENOMEM;

	return ret;

}

EXPORT_SYMBOL_GPL(posix_acl_create);