Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be9614e1 authored by Baokun Li's avatar Baokun Li Committed by Greg Kroah-Hartman
Browse files

ext4: correct max_inline_xattr_value_size computing 



commit c9fd167d57133c5b748d16913c4eabc55e531c73 upstream.

If the ext4 inode does not have xattr space, 0 is returned in the
get_max_inline_xattr_value_size function. Otherwise, the function returns
a negative value when the inode does not contain EXT4_STATE_XATTR.

Cc: stable@kernel.org
Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarRitesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220616021358.2504451-4-libaokun1@huawei.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b9a2dfd1

fs/ext4/inline.c

+3 −0
Original line number Diff line number Diff line
@@ -34,6 +34,9 @@ static int get_max_inline_xattr_value_size(struct inode *inode, 
	struct ext4_inode *raw_inode;

	int free, min_offs;



	if (!EXT4_INODE_HAS_XATTR_SPACE(inode))

		return 0;



	min_offs = EXT4_SB(inode->i_sb)->s_inode_size -

			EXT4_GOOD_OLD_INODE_SIZE -

			EXT4_I(inode)->i_extra_isize -