Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be688195 authored by Haggai Eran's avatar Haggai Eran Committed by Doug Ledford
Browse files

IB/cma: Fix net_dev reference leak with failed requests



When no matching listening ID is found for a given request, the net_dev
that was used to find the request isn't released.

Fixes: 0b3ca768 ("IB/cma: Use found net_dev for passive connections")
Signed-off-by: default avatarHaggai Eran <haggaie@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 73fec7fd
Loading
Loading
Loading
Loading
+4 −0
Original line number Original line Diff line number Diff line
@@ -1302,6 +1302,10 @@ static struct rdma_id_private *cma_id_from_event(struct ib_cm_id *cm_id,
	bind_list = cma_ps_find(rdma_ps_from_service_id(req.service_id),
	bind_list = cma_ps_find(rdma_ps_from_service_id(req.service_id),
				cma_port_from_service_id(req.service_id));
				cma_port_from_service_id(req.service_id));
	id_priv = cma_find_listener(bind_list, cm_id, ib_event, &req, *net_dev);
	id_priv = cma_find_listener(bind_list, cm_id, ib_event, &req, *net_dev);
	if (IS_ERR(id_priv)) {
		dev_put(*net_dev);
		*net_dev = NULL;
	}


	return id_priv;
	return id_priv;
}
}