Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdc9f373 authored by Rusty Russell's avatar Rusty Russell
Browse files

jump_label: disable preemption around __module_text_address(). 



Steven reported a warning caused by not holding module_mutex or
rcu_read_lock_sched: his backtrace was corrupted but a quick audit
found this possible cause.  It's wrong anyway...

Reported-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 0ef76537

kernel/jump_label.c

+4 −1
Original line number Diff line number Diff line
@@ -284,11 +284,14 @@ static int __jump_label_mod_text_reserved(void *start, void *end) 
{

	struct module *mod;



	preempt_disable();

	mod = __module_text_address((unsigned long)start);

	WARN_ON_ONCE(__module_text_address((unsigned long)end) != mod);

	preempt_enable();



	if (!mod)

		return 0;



	WARN_ON_ONCE(__module_text_address((unsigned long)end) != mod);



	return __jump_label_text_reserved(mod->jump_entries,

				mod->jump_entries + mod->num_jump_entries,