Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bdba48d5 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

mt76: usb: fix possible NULL pointer dereference in mt76u_mcu_deinit 



Fix possible NULL pointer dereference in mt76u_mcu_deinit routine that
can occur if initialization path fails before calling mt76u_mcu_init_rx

Fixes: ee676cd5 ("mt76: add driver code for MT76x2u based devices")
Signed-off-by: default avatarLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 5de4db8f

drivers/net/wireless/mediatek/mt76/usb_mcu.c

+5 −3
Original line number Diff line number Diff line
@@ -48,9 +48,11 @@ EXPORT_SYMBOL_GPL(mt76u_mcu_init_rx); 


void mt76u_mcu_deinit(struct mt76_dev *dev)

{

	struct mt76_usb *usb = &dev->usb;

	struct mt76u_buf *buf = &dev->usb.mcu.res;



	usb_kill_urb(usb->mcu.res.urb);

	mt76u_buf_free(&usb->mcu.res);

	if (buf->urb) {

		usb_kill_urb(buf->urb);

		mt76u_buf_free(buf);

	}

}

EXPORT_SYMBOL_GPL(mt76u_mcu_deinit);