Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd7e31bb authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab
Browse files

[media] ir-core: fix gcc-7 warning on bool arithmetic 



gcc-7 suggests that an expression using a bitwise not and a bitmask
on a 'bool' variable is better written using boolean logic:

drivers/media/rc/imon.c: In function 'imon_incoming_scancode':
drivers/media/rc/imon.c:1725:22: error: '~' on a boolean expression [-Werror=bool-operation]
    ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1;
                      ^
drivers/media/rc/imon.c:1725:22: note: did you mean to use logical not?

I agree.

Fixes: 21677cfc ("V4L/DVB: ir-core: add imon driver")

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 54221e72

drivers/media/rc/imon.c

+1 −1
Original line number Diff line number Diff line
@@ -1722,7 +1722,7 @@ static void imon_incoming_scancode(struct imon_context *ictx, 
	if (kc == KEY_KEYBOARD && !ictx->release_code) {

		ictx->last_keycode = kc;

		if (!nomouse) {

			ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1;

			ictx->pad_mouse = !ictx->pad_mouse;

			dev_dbg(dev, "toggling to %s mode\n",

				ictx->pad_mouse ? "mouse" : "keyboard");

			spin_unlock_irqrestore(&ictx->kc_lock, flags);