Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd5122cd authored by Tarick Bedeir's avatar Tarick Bedeir Committed by David S. Miller
Browse files

net/mlx4_core: Correctly set PFC param if global pause is turned off. 



rx_ppp and tx_ppp can be set between 0 and 255, so don't clamp to 1.

Fixes: 6e8814ce ("net/mlx4_en: Fix mixed PFC and Global pause user control requests")
Signed-off-by: default avatarTarick Bedeir <tarick@google.com>
Reviewed-by: default avatarEran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5b3279e2

drivers/net/ethernet/mellanox/mlx4/en_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -1084,8 +1084,8 @@ static int mlx4_en_set_pauseparam(struct net_device *dev, 


	tx_pause = !!(pause->tx_pause);

	rx_pause = !!(pause->rx_pause);

	rx_ppp = priv->prof->rx_ppp && !(tx_pause || rx_pause);

	tx_ppp = priv->prof->tx_ppp && !(tx_pause || rx_pause);

	rx_ppp = (tx_pause || rx_pause) ? 0 : priv->prof->rx_ppp;

	tx_ppp = (tx_pause || rx_pause) ? 0 : priv->prof->tx_ppp;



	err = mlx4_SET_PORT_general(mdev->dev, priv->port,

				    priv->rx_skb_size + ETH_FCS_LEN,