Commit bd1cd32c authored Jul 12, 2021 by Colin Ian King Committed by Greg Kroah-Hartman Sep 15, 2021

6lowpan: iphc: Fix an off-by-one check of array index



[ Upstream commit 9af417610b6142e826fd1ee8ba7ff3e9a2133a5a ]

The bounds check of id is off-by-one and the comparison should
be >= rather >. Currently the WARN_ON_ONCE check does not stop
the out of range indexing of &ldev->ctx.table[id] so also add
a return path if the bounds are out of range.

Addresses-Coverity: ("Illegal address computation").
Fixes: 5609c185 ("6lowpan: iphc: add support for stateful compression")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c4895cf4

net/6lowpan/debugfs.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -170,7 +170,8 @@ static void lowpan_dev_debugfs_ctx_init(struct net_device *dev,
		struct dentry *root;
		char buf[32];

		WARN_ON_ONCE(id > LOWPAN_IPHC_CTX_TABLE_SIZE);
		if (WARN_ON_ONCE(id >= LOWPAN_IPHC_CTX_TABLE_SIZE))
		return;

		sprintf(buf, "%d", id);