Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcce46e1 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by Greg Kroah-Hartman
Browse files

media: stv0288: use explicitly signed char 



commit 7392134428c92a4cb541bd5c8f4f5c8d2e88364d upstream.

With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. Use `s8` and `u8` types here, since that's what
surrounding code does. This fixes:

drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm'
drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop

Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent de2ea2a0

drivers/media/dvb-frontends/stv0288.c

+2 −3
Original line number Diff line number Diff line
@@ -440,9 +440,8 @@ static int stv0288_set_frontend(struct dvb_frontend *fe) 
	struct stv0288_state *state = fe->demodulator_priv;

	struct dtv_frontend_properties *c = &fe->dtv_property_cache;



	char tm;

	unsigned char tda[3];

	u8 reg, time_out = 0;

	u8 tda[3], reg, time_out = 0;

	s8 tm;



	dprintk("%s : FE_SET_FRONTEND\n", __func__);