Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcc2661e authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Only show debug for state changes when banning 



Since we trigger 10,000s of hangs and resets during selftesting, we emit
many, many thousands of lines of useless debug messages. Reduce the
frequency by only logging a change in state of a guilty context.

Fixes: 14921f3c ("drm/i915: Fix context ban and hang accounting for client")
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180618073135.10849-1-chris@chris-wilson.co.uk
parent 02f361f5

drivers/gpu/drm/i915/i915_gem.c

+5 −5
Original line number Diff line number Diff line
@@ -2976,16 +2976,16 @@ static void i915_gem_context_mark_guilty(struct i915_gem_context *ctx) 
	score = atomic_add_return(CONTEXT_SCORE_GUILTY, &ctx->ban_score);

	banned = score >= CONTEXT_SCORE_BAN_THRESHOLD;



	DRM_DEBUG_DRIVER("context %s: guilty %d, score %u, ban %s\n",

			 ctx->name, atomic_read(&ctx->guilty_count),

			 score, yesno(banned && bannable));



	/* Cool contexts don't accumulate client ban score */

	if (!bannable)

		return;



	if (banned)

	if (banned) {

		DRM_DEBUG_DRIVER("context %s: guilty %d, score %u, banned\n",

				 ctx->name, atomic_read(&ctx->guilty_count),

				 score);

		i915_gem_context_set_banned(ctx);

	}



	if (!IS_ERR_OR_NULL(ctx->file_priv))

		i915_gem_client_mark_guilty(ctx->file_priv, ctx);