Commit bcb6c4c5 authored May 12, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jun 14, 2022

powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup



[ Upstream commit fcee96924ba1596ca80a6770b2567ca546f9a482 ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: abc3aeae ("fsl-rio: Add two ports and rapidio message units support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220512123724.62931-1-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2631fe5b

arch/powerpc/sysdev/fsl_rio.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -505,8 +505,10 @@ int fsl_rio_setup(struct platform_device *dev)
	if (rc) {		if (rc) {
	dev_err(&dev->dev, "Can't get %pOF property 'reg'\n",		dev_err(&dev->dev, "Can't get %pOF property 'reg'\n",
	rmu_node);		rmu_node);
			of_node_put(rmu_node);
	goto err_rmu;		goto err_rmu;
	}		}
			of_node_put(rmu_node);
	rmu_regs_win = ioremap(rmu_regs.start, resource_size(&rmu_regs));		rmu_regs_win = ioremap(rmu_regs.start, resource_size(&rmu_regs));
	if (!rmu_regs_win) {		if (!rmu_regs_win) {
	dev_err(&dev->dev, "Unable to map rmu register window\n");		dev_err(&dev->dev, "Unable to map rmu register window\n");