Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc4fcd0a authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

r8169: remove version info 



The version number hasn't changed for ages and in general I doubt it
provides any benefit. The message in rtl_init_one() may even be
misleading because it's printed also if something fails in probe.
Therefore let's remove the version information.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0780b866

drivers/net/ethernet/realtek/r8169.c

+0 −8
Original line number Original line Diff line number Diff line
@@ -32,7 +32,6 @@ 
#include <asm/io.h>

#include <asm/io.h>

#include <asm/irq.h>

#include <asm/irq.h>





#define RTL8169_VERSION "2.3LK-NAPI"

#define MODULENAME "r8169"

#define MODULENAME "r8169"





#define FIRMWARE_8168D_1	"rtl_nic/rtl8168d-1.fw"

#define FIRMWARE_8168D_1	"rtl_nic/rtl8168d-1.fw"
@@ -784,7 +783,6 @@ MODULE_PARM_DESC(use_dac, "Enable PCI DAC. Unsafe on 32 bit PCI slot."); 
module_param_named(debug, debug.msg_enable, int, 0);

module_param_named(debug, debug.msg_enable, int, 0);

MODULE_PARM_DESC(debug, "Debug verbosity level (0=none, ..., 16=all)");

MODULE_PARM_DESC(debug, "Debug verbosity level (0=none, ..., 16=all)");

MODULE_LICENSE("GPL");

MODULE_LICENSE("GPL");

MODULE_VERSION(RTL8169_VERSION);

MODULE_FIRMWARE(FIRMWARE_8168D_1);

MODULE_FIRMWARE(FIRMWARE_8168D_1);

MODULE_FIRMWARE(FIRMWARE_8168D_2);

MODULE_FIRMWARE(FIRMWARE_8168D_2);

MODULE_FIRMWARE(FIRMWARE_8168E_1);

MODULE_FIRMWARE(FIRMWARE_8168E_1);
@@ -1635,7 +1633,6 @@ static void rtl8169_get_drvinfo(struct net_device *dev, 
	struct rtl_fw *rtl_fw = tp->rtl_fw;

	struct rtl_fw *rtl_fw = tp->rtl_fw;





	strlcpy(info->driver, MODULENAME, sizeof(info->driver));

	strlcpy(info->driver, MODULENAME, sizeof(info->driver));

	strlcpy(info->version, RTL8169_VERSION, sizeof(info->version));

	strlcpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info));

	strlcpy(info->bus_info, pci_name(tp->pci_dev), sizeof(info->bus_info));

	BUILD_BUG_ON(sizeof(info->fw_version) < sizeof(rtl_fw->version));

	BUILD_BUG_ON(sizeof(info->fw_version) < sizeof(rtl_fw->version));

	if (!IS_ERR_OR_NULL(rtl_fw))

	if (!IS_ERR_OR_NULL(rtl_fw))
@@ -7292,11 +7289,6 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 
	int chipset, region, i;

	int chipset, region, i;

	int rc;

	int rc;





	if (netif_msg_drv(&debug)) {

		printk(KERN_INFO "%s Gigabit Ethernet driver %s loaded\n",

		       MODULENAME, RTL8169_VERSION);

	}



	dev = devm_alloc_etherdev(&pdev->dev, sizeof (*tp));

	dev = devm_alloc_etherdev(&pdev->dev, sizeof (*tp));

	if (!dev)

	if (!dev)

		return -ENOMEM;

		return -ENOMEM;