Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc3f5d8c authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Alex Deucher
Browse files

drm/radeon: use post-decrement in error handling 



We need to use post-decrement to get the pci_map_page undone also for
i==0, and to avoid some very unpleasant behaviour if pci_map_page
failed already at i==0.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 09ccbb74

drivers/gpu/drm/radeon/radeon_ttm.c

+1 −1
Original line number Diff line number Diff line
@@ -758,7 +758,7 @@ static int radeon_ttm_tt_populate(struct ttm_tt *ttm) 
						       0, PAGE_SIZE,

						       PCI_DMA_BIDIRECTIONAL);

		if (pci_dma_mapping_error(rdev->pdev, gtt->ttm.dma_address[i])) {

			while (--i) {

			while (i--) {

				pci_unmap_page(rdev->pdev, gtt->ttm.dma_address[i],

					       PAGE_SIZE, PCI_DMA_BIDIRECTIONAL);

				gtt->ttm.dma_address[i] = 0;