Commit bc35f73a authored Jul 08, 2017 by Christos Gkekas Committed by Jiri Kosina Jul 20, 2017

HID: wacom: Remove comparison of u8 mode with zero and simplify.



Variable mode in method wacom_show_remote_mode() is defined as u8, thus
statement (mode >= 0) is always true and should be removed, simplifying
the logic.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent a91ab911

drivers/hid/wacom_sys.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1671,10 +1671,7 @@ static ssize_t wacom_show_remote_mode(struct kobject *kobj,
		u8 mode;

		mode = wacom->led.groups[index].select;
		if (mode >= 0 && mode < 3)
		return snprintf(buf, PAGE_SIZE, "%d\n", mode);
		else
		return snprintf(buf, PAGE_SIZE, "%d\n", -1);
		return sprintf(buf, "%d\n", mode < 3 ? mode : -1);
		}

		#define DEVICE_EKR_ATTR_GROUP(SET_ID) \