Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc1af47d authored by Wolfram Sang's avatar Wolfram Sang Committed by David S. Miller
Browse files

net: can: usb: kvaser_usb: don't print error when allocating urb fails 



kmalloc will print enough information in case of failure.

Signed-off-by: default avatarWolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2a4a1e40

drivers/net/can/usb/kvaser_usb.c

+1 −6
Original line number Original line Diff line number Diff line
@@ -787,10 +787,8 @@ static int kvaser_usb_simple_msg_async(struct kvaser_usb_net_priv *priv, 
	int err;

	int err;





	urb = usb_alloc_urb(0, GFP_ATOMIC);

	urb = usb_alloc_urb(0, GFP_ATOMIC);

	if (!urb) {

	if (!urb)

		netdev_err(netdev, "No memory left for URBs\n");

		return -ENOMEM;

		return -ENOMEM;

	}





	buf = kmalloc(sizeof(struct kvaser_msg), GFP_ATOMIC);

	buf = kmalloc(sizeof(struct kvaser_msg), GFP_ATOMIC);

	if (!buf) {

	if (!buf) {
@@ -1393,8 +1391,6 @@ static int kvaser_usb_setup_rx_urbs(struct kvaser_usb *dev) 




		urb = usb_alloc_urb(0, GFP_KERNEL);

		urb = usb_alloc_urb(0, GFP_KERNEL);

		if (!urb) {

		if (!urb) {

			dev_warn(dev->udev->dev.parent,

				 "No memory left for URBs\n");

			err = -ENOMEM;

			err = -ENOMEM;

			break;

			break;

		}

		}
@@ -1670,7 +1666,6 @@ static netdev_tx_t kvaser_usb_start_xmit(struct sk_buff *skb, 




	urb = usb_alloc_urb(0, GFP_ATOMIC);

	urb = usb_alloc_urb(0, GFP_ATOMIC);

	if (!urb) {

	if (!urb) {

		netdev_err(netdev, "No memory left for URBs\n");

		stats->tx_dropped++;

		stats->tx_dropped++;

		dev_kfree_skb(skb);

		dev_kfree_skb(skb);

		return NETDEV_TX_OK;

		return NETDEV_TX_OK;