Commit bbe293db authored Aug 24, 2022 by Lam Thai Committed by Greg Kroah-Hartman Oct 26, 2022

bpftool: Fix a wrong type cast in btf_dumper_int



[ Upstream commit 7184aef9c0f7a81db8fd18d183ee42481d89bf35 ]

When `data` points to a boolean value, casting it to `int *` is problematic
and could lead to a wrong value being passed to `jsonw_bool`. Change the
cast to `bool *` instead.

Fixes: b12d6ec0 ("bpf: btf: add btf print functionality")
Signed-off-by: Lam Thai <lamthai@arista.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20220824225859.9038-1-lamthai@arista.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9ee70c3c

tools/bpf/bpftool/btf_dumper.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -251,7 +251,7 @@ static int btf_dumper_int(const struct btf_type *t, __u8 bit_offset,
	(char )data);		(char )data);
	break;		break;
	case BTF_INT_BOOL:		case BTF_INT_BOOL:
	jsonw_bool(jw, (int )data);		jsonw_bool(jw, (bool )data);
	break;		break;
	default:		default:
	/* shouldn't happen */		/* shouldn't happen */