Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbd51924 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Al Viro
Browse files

proc: Update proc_flush_task_mnt to use d_invalidate 



Now that d_invalidate always succeeds and flushes mount points use
it in stead of a combination of shrink_dcache_parent and d_drop
in proc_flush_task_mnt.  This removes the danger of a mount point
under /proc/<pid>/... becoming unreachable after the d_drop.

Reviewed-by: default avatarMiklos Szeredi <miklos@szeredi.hu>
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent c143c233

fs/proc/base.c

+2 −4
Original line number Diff line number Diff line
@@ -2639,8 +2639,7 @@ static void proc_flush_task_mnt(struct vfsmount *mnt, pid_t pid, pid_t tgid) 
	/* no ->d_hash() rejects on procfs */

	dentry = d_hash_and_lookup(mnt->mnt_root, &name);

	if (dentry) {

		shrink_dcache_parent(dentry);

		d_drop(dentry);

		d_invalidate(dentry);

		dput(dentry);

	}
@@ -2660,8 +2659,7 @@ static void proc_flush_task_mnt(struct vfsmount *mnt, pid_t pid, pid_t tgid) 
	name.len = snprintf(buf, sizeof(buf), "%d", pid);

	dentry = d_hash_and_lookup(dir, &name);

	if (dentry) {

		shrink_dcache_parent(dentry);

		d_drop(dentry);

		d_invalidate(dentry);

		dput(dentry);

	}