Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb896805 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

staging: fsl-dpaa2: ethsw: Introduce ethsw_port_dev_check() 



ethsw currently uses an open-coded comparison of netdev_ops to determine
whether whether a device represents a front panel port. Wrap this into a
named function to simplify reuse.

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b239f67

drivers/staging/fsl-dpaa2/ethsw/ethsw.c

+6 −1
Original line number Diff line number Diff line
@@ -972,6 +972,11 @@ static int port_bridge_leave(struct net_device *netdev) 
	return err;

}



static bool ethsw_port_dev_check(const struct net_device *netdev)

{

	return netdev->netdev_ops == &ethsw_port_ops;

}



static int port_netdevice_event(struct notifier_block *unused,

				unsigned long event, void *ptr)

{
@@ -980,7 +985,7 @@ static int port_netdevice_event(struct notifier_block *unused, 
	struct net_device *upper_dev;

	int err = 0;



	if (netdev->netdev_ops != &ethsw_port_ops)

	if (!ethsw_port_dev_check(netdev))

		return NOTIFY_DONE;



	/* Handle just upper dev link/unlink for the moment */