Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb2ab10f authored by Artem Bityutskiy's avatar Artem Bityutskiy Committed by Linus Torvalds
Browse files

lib/list_sort: test: use more reasonable printk levels 



I do not see any reason to use KERN_WARN for normal messages and
KERN_EMERG for error messages in the lib_sort testing routine.  Let's use
more reasonable KERN_NORM and KERN_ERR levels.

Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: Don Mullis <don.mullis@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6d411e6c

lib/list_sort.c

+8 −8
Original line number Original line Diff line number Diff line
@@ -166,7 +166,7 @@ static int __init list_sort_test(void) 
	struct list_head *head = kmalloc(sizeof(*head), GFP_KERNEL);

	struct list_head *head = kmalloc(sizeof(*head), GFP_KERNEL);

	struct list_head *cur;

	struct list_head *cur;





	printk(KERN_WARNING "testing list_sort()\n");

	printk(KERN_DEBUG "testing list_sort()\n");





	cur = head;

	cur = head;

	for (i = 0; i < LIST_SORT_TEST_LENGTH; i++) {

	for (i = 0; i < LIST_SORT_TEST_LENGTH; i++) {
@@ -189,16 +189,16 @@ static int __init list_sort_test(void) 
		struct debug_el *el = container_of(cur, struct debug_el, l_h);

		struct debug_el *el = container_of(cur, struct debug_el, l_h);

		int cmp_result = cmp(NULL, cur, cur->next);

		int cmp_result = cmp(NULL, cur, cur->next);

		if (cur->next->prev != cur) {

		if (cur->next->prev != cur) {

			printk(KERN_EMERG "list_sort() returned "

			printk(KERN_ERR "list_sort() returned "

					"a corrupted list!\n");

					"a corrupted list!\n");

			return 1;

			return 1;

		} else if (cmp_result > 0) {

		} else if (cmp_result > 0) {

			printk(KERN_EMERG "list_sort() failed to sort!\n");

			printk(KERN_ERR "list_sort() failed to sort!\n");

			return 1;

			return 1;

		} else if (cmp_result == 0 &&

		} else if (cmp_result == 0 &&

				el->serial >= container_of(cur->next,

				el->serial >= container_of(cur->next,

					struct debug_el, l_h)->serial) {

					struct debug_el, l_h)->serial) {

			printk(KERN_EMERG "list_sort() failed to preserve order"

			printk(KERN_ERR "list_sort() failed to preserve order "

					"of equivalent elements!\n");

					"of equivalent elements!\n");

			return 1;

			return 1;

		}

		}
@@ -207,7 +207,7 @@ static int __init list_sort_test(void) 
	}

	}

	kfree(cur);

	kfree(cur);

	if (count != LIST_SORT_TEST_LENGTH) {

	if (count != LIST_SORT_TEST_LENGTH) {

		printk(KERN_EMERG "list_sort() returned list of"

		printk(KERN_ERR "list_sort() returned list of "

				"different length!\n");

				"different length!\n");

		return 1;

		return 1;

	}

	}