Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb22c36c authored Oct 08, 2018 by Somnath Kotur Committed by Jason Gunthorpe Oct 16, 2018

RDMA/bnxt_re: Prevent driver crash due to NULL pointer in error message print



crsqe->resp would be NULL in case the host command timed out before
getting a response from HW. Check for NULL pointer to avoid a potential
crash while printing the error message.

Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent f2bd4d09

drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -333,10 +333,12 @@ static int bnxt_qplib_process_qp_event(struct bnxt_qplib_rcfw *rcfw,
		memcpy(crsqe->resp, qp_event, sizeof(*qp_event));
		crsqe->resp = NULL;
		} else {
		if (crsqe->resp && crsqe->resp->cookie)
		dev_err(&rcfw->pdev->dev,
		"CMD %s resp->cookie = %#x, evnt->cookie = %#x\n",
		"CMD %s cookie sent=%#x, recd=%#x\n",
		crsqe->resp ? "mismatch" : "collision",
		crsqe->resp ? crsqe->resp->cookie : 0, mcookie);
		crsqe->resp ? crsqe->resp->cookie : 0,
		mcookie);
		}
		if (!test_and_clear_bit(cbit, rcfw->cmdq_bitmap))
		dev_warn(&rcfw->pdev->dev,