Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba828cc9 authored by Alexander Shishkin's avatar Alexander Shishkin
Browse files

intel_th: Only create useful device nodes 



Right now, the driver will create a device node for each output port,
with the intent to provide read access to that port's data. However,
only the memory ports are readable this way (msc0, msc1). Other output
ports don't need device nodes, so remove them.

Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
parent 8d86f6b4

drivers/hwtracing/intel_th/core.c

+5 −1
Original line number Diff line number Diff line
@@ -422,6 +422,7 @@ static const struct intel_th_subdevice { 
	unsigned		nres;

	unsigned		type;

	unsigned		otype;

	bool			mknode;

	unsigned		scrpd;

	int			id;

} intel_th_subdevices[] = {
@@ -456,6 +457,7 @@ static const struct intel_th_subdevice { 
		.name	= "msc",

		.id	= 0,

		.type	= INTEL_TH_OUTPUT,

		.mknode	= true,

		.otype	= GTH_MSU,

		.scrpd	= SCRPD_MEM_IS_PRIM_DEST | SCRPD_MSC0_IS_ENABLED,

	},
@@ -476,6 +478,7 @@ static const struct intel_th_subdevice { 
		.name	= "msc",

		.id	= 1,

		.type	= INTEL_TH_OUTPUT,

		.mknode	= true,

		.otype	= GTH_MSU,

		.scrpd	= SCRPD_MEM_IS_PRIM_DEST | SCRPD_MSC1_IS_ENABLED,

	},
@@ -635,6 +638,7 @@ intel_th_subdevice_alloc(struct intel_th *th, 
	}



	if (subdev->type == INTEL_TH_OUTPUT) {

		if (subdev->mknode)

			thdev->dev.devt = MKDEV(th->major, th->num_thdevs);

		thdev->output.type = subdev->otype;

		thdev->output.port = -1;