Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba508685 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: fix incorrect strncasecmp length 



The strncasecmp of buff against the literal string RSSI
is using variable length which is zero. This should be instead
using the variable size instead.  Also remove the redundant
variable length.

Detected by PVS-Studio, warning: V575

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0e490657

drivers/staging/wilc1000/linux_wlan.c

+2 −2
Original line number Diff line number Diff line
@@ -1074,7 +1074,7 @@ static int mac_ioctl(struct net_device *ndev, struct ifreq *req, int cmd) 
{

	u8 *buff = NULL;

	s8 rssi;

	u32 size = 0, length = 0;

	u32 size = 0;

	struct wilc_vif *vif;

	s32 ret = 0;

	struct wilc *wilc;
@@ -1098,7 +1098,7 @@ static int mac_ioctl(struct net_device *ndev, struct ifreq *req, int cmd) 
			if (IS_ERR(buff))

				return PTR_ERR(buff);



			if (strncasecmp(buff, "RSSI", length) == 0) {

			if (strncasecmp(buff, "RSSI", size) == 0) {

				ret = wilc_get_rssi(vif, &rssi);

				netdev_info(ndev, "RSSI :%d\n", rssi);