Commit ba0fd56a authored Feb 06, 2011 by Jesper Juhl Committed by Mauro Carvalho Chehab Mar 21, 2011

[media] TTUSB DVB: ttusb_boot_dsp() needs to release_firmware() or it leaks memory



In drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c:ttusb_boot_dsp() we
need to call release_firmware(fw) before returning or we'll leak - no
matter if we succeed or fail.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 19a0a296

drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -334,6 +334,7 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
		err = ttusb_cmd(ttusb, b, 4, 0);

		done:
		release_firmware(fw);
		if (err) {
		dprintk("%s: usb_bulk_msg() failed, return value %i!\n",
		__func__, err);