Commit b9e5f633 authored Nov 10, 2023 by Mahmoud Adam Committed by Greg Kroah-Hartman Nov 28, 2023

nfsd: fix file memleak on client_opens_release



commit bc1b5acb40201a0746d68a7d7cfc141899937f4f upstream.

seq_release should be called to free the allocated seq_file

Cc: stable@vger.kernel.org # v5.3+
Signed-off-by: Mahmoud Adam <mngyadam@amazon.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Fixes: 78599c42 ("nfsd4: add file to display list of client's opens")
Reviewed-by: NeilBrown <neilb@suse.de>
Tested-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 339d7d40

fs/nfsd/nfs4state.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2571,7 +2571,7 @@ static int client_opens_release(struct inode inode, struct file file)

		/* XXX: alternatively, we could get/drop in seq start/stop */
		drop_client(clp);
		return 0;
		return seq_release(inode, file);
		}

		static const struct file_operations client_states_fops = {