Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9b8a41a authored by Dan Carpenter's avatar Dan Carpenter Committed by David Sterba
Browse files

btrfs: use after free in btrfs_quota_enable 



The issue here is that btrfs_commit_transaction() frees "trans" on both
the error and the success path.  So the problem would be if
btrfs_commit_transaction() succeeds, and then qgroup_rescan_init()
fails.  That means that "ret" is non-zero and "trans" is non-NULL and it
leads to a use after free inside the btrfs_end_transaction() macro.

Fixes: 340f1aa2 ("btrfs: qgroups: Move transaction management inside btrfs_quota_enable/disable")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 801660b0

fs/btrfs/qgroup.c

+2 −3
Original line number Diff line number Diff line
@@ -1019,10 +1019,9 @@ int btrfs_quota_enable(struct btrfs_fs_info *fs_info) 
	spin_unlock(&fs_info->qgroup_lock);



	ret = btrfs_commit_transaction(trans);

	if (ret) {

	trans = NULL;

	if (ret)

		goto out_free_path;

	}



	ret = qgroup_rescan_init(fs_info, 0, 1);

	if (!ret) {